[linux-dvb] Re: [PATCH?] proposed rewrite of skystar2 filters

[Niklas Peinecke <peinecke@gdv.uni-hannover.de>]

Holger Waechtler wrote:
> Niklas Peinecke wrote:
>
> > OK, here is another patch. I incorporated the enable_hw_filters 
> > parameter and also implemented ref counting for every pid. I defaulted 
> > it to 1 (see my previous post for the reason). Setting it to 0 
> > disables the filters alltogether by just calling open_whole_bandwidth 
> > (I'm not sure if this is what you were intending, feel free to make 
> > any changes you like).
> >
> > Also there are now _two_ ref counters for open_whole_bandwidth: one 
> > triggered by overflow (i.e. all hw filters in use) and one by special 
> > pid 0x2000. This is necessary to avoid the situation that you can 
> > close down the ts (opened by overflow) by removing a 0x2000 that was 
> > not added.
>
> I failed to apply your patch because it conflicts with the new DiSEqC 
> stuff. Can you please merge the code and prepare a new patch?
>
> Holger
Hi everybody,

I'm sorry, I'm a bit confused now (and partly I think this is my own 
fault). Could somebody please tell me what I should do now?

* As suggested by Wolfgang I could implement a separate ref counter for 
every pid. I think 8 bit should be really sufficient?
* Where should I start? Wolfgang submitted two patches, one should work 
with actual CVS. If not, I'll be waiting for feedback and then try to 
incorporate into the CVS.
* If you really can be sure that there will be no request to remove a 
0x2000 pid that was not added, then Wolfgang is right and we need only 
one ref counter for open_whole_bandwidth.

Thanks for all your work, I think the driver is getting better and better!

Niklas



--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.